Very often I have to review pull requests of fellow programmers and I face the problem - what should I do when the code is not as good as I would expect? Should I reject the pull request or accept/merge even though I don't like the code? Of course, I reject when I see errors, but I can't keep rejecting again and again. This annoys my colleagues and they ask me to close my eyes and move on. But if I accept the changes I don't like - what code review is for? What can you recommend?
Asked
Active
Viewed 81 times
