Why does microsoft's own included MVC3 template not follow fat models, skinny controllers?

Question

From Microsoft's own built in template for MVC3

The model is extremely skinny, having basically no code.

Model

public class RegisterModel
{
    [Required]
    [Display(Name = "User name")]
    public string UserName { get; set; }

    [Required]
    [DataType(DataType.EmailAddress)]
    [Display(Name = "Email address")]
    public string Email { get; set; }

    [Required]
    [StringLength(100, ErrorMessage = "The {0} must be at least {2} characters long.", MinimumLength = 6)]
    [DataType(DataType.Password)]
    [Display(Name = "Password")]
    public string Password { get; set; }

    [DataType(DataType.Password)]
    [Display(Name = "Confirm password")]
    [Compare("Password", ErrorMessage = "The password and confirmation password do not match.")]
    public string ConfirmPassword { get; set; }
}

While the Controller on the other hand seems to be fat, doing more that simple routing...

Controller

[HttpPost]
[AllowAnonymous]
public ActionResult Register(RegisterModel model)
{
    if (ModelState.IsValid)
    {
        // Attempt to register the user
        MembershipCreateStatus createStatus;
        Membership.CreateUser(model.UserName, model.Password, model.Email, null, null, true, null, out createStatus);

        if (createStatus == MembershipCreateStatus.Success)
        {
            FormsAuthentication.SetAuthCookie(model.UserName, false /* createPersistentCookie */);
            return RedirectToAction("Index", "Home");
        }
        else
        {
            ModelState.AddModelError("", ErrorCodeToString(createStatus));
        }
    }

    // If we got this far, something failed, redisplay form
    return View(model);
}

score 6 · Answer 1 · edited Sep 20 '11 at 14:34

6

Everything the controller is doing there is its job, its pretty basic stuff. Business logic is not going to be generated for you. Models get fat when you encapsulate useful functionality into them; you can't expect to see that from a template.

edited Sep 20 '11 at 14:34

Robert Harvey

200,592

answered Jun 02 '11 at 00:07

Jeremy

4,597

score 0 · Answer 2 · answered Sep 20 '11 at 15:07

0

I'm curious how you think the controller could be put on a diet? I honestly can't see anything there that could move to the model without violating SRP.

answered Sep 20 '11 at 15:07

Bryan B

2,814

Why does microsoft's own included MVC3 template not follow fat models, skinny controllers?

2 Answers2